Issue #215 resolved

Compiler warnings

epich
created an issue

Output of make:

: make
Compute dependencies
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-common.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-common.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-core.el

In end of data:
evil-core.el:1066:1:Warning: the function `deactivate-input-method' is not
    known to be defined.
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-core.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-states.el

In end of data:
evil-states.el:860:1:Warning: the function `deactivate-input-method' is not
    known to be defined.
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-states.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-ex.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-ex.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-search.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-search.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-repeat.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-repeat.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-macros.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-macros.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-types.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-types.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-commands.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-commands.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-maps.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-maps.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil-integration.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil-integration.elc
emacs --batch -Q -L . -L lib -f batch-byte-compile evil.el
Wrote /home/boreilly/unihome/rc/.emacs.d/evil/evil.elc

When I moved the compatibility lines from evil-integration.el to evil-common.el, I compiled without warnings. Patch:

diff --git a/evil-common.el b/evil-common.el
index 8f032d0..1746527 100644
--- a/evil-common.el
+++ b/evil-common.el
@@ -26,6 +26,12 @@

 ;;; Code:

+;;; Compatibility for Emacs 23
+(unless (fboundp 'deactivate-input-method)
+  (defalias 'deactivate-input-method 'inactivate-input-method))
+(unless (boundp 'input-method-deactivate-hook)
+  (defalias 'input-method-deactivate-hook 'input-method-inactivate-hook))
+
 (condition-case nil
     (require 'windmove)
   (error
diff --git a/evil-integration.el b/evil-integration.el
index 54d3dc2..a7c8342 100644
--- a/evil-integration.el
+++ b/evil-integration.el
@@ -27,12 +27,6 @@

 ;;; Code:

-;;; Compatibility for Emacs 23
-(unless (fboundp 'deactivate-input-method)
-  (defalias 'deactivate-input-method 'inactivate-input-method))
-(unless (boundp 'input-method-deactivate-hook)
-  (defalias 'input-method-deactivate-hook 'input-method-inactivate-hook))
-
 ;;; Evilize some commands

 (mapc #'(lambda (cmd)

Comments (3)

  1. Log in to comment