Cursor keys do random edits

Issue #57 new
Former user created an issue

Holy crap. I tried to scroll the page by pressing the cursor keys and it looks like they trigger edits!

Comments (9)

  1. Waldir Pimenta

    This is not that serious since the key most likely to be hit by mistake is down, and that only skips the current item -- no edits are committed to wikidata (so, for now, I'll change the priority from critical down to major).

    Issue #29 could alleviate this issue, but it could be wise to ask the user if they really want to commit actions in the came the first time they press any of the hotkeys. This only needs to be done once if the alert shows all current available shortcuts.

  2. TMg_

    Wait, what? I know the game implements hotkeys (the numbers), but if a scroll key triggers something unrelated to scrolling this can't be intended and must a bug, right? The game is made to be played on all screen sizes, right? Scrolling is a normal thing then. And even if scrolling left and right is not necessary this doesn't mean you can hijack these keys and do something completely different.

  3. Waldir Pimenta

    @TMg_ so what's your stance? Would you be ok with warning the user the first time they press one of the hotkeys, as suggested above, or do you think we should disable the arrow keys shortcuts altogether?

  4. TMg_

    I don't understand. Why do the number hotkeys affect the cursor keys? There is no way this can go together:

    • Cursor keys = scrolling.
    • Hotkeys = stuff like Alt+N or W A S D or 1 2 3 that you usually don't need to navigate web pages.

    Why should it be intended that something completely different, undocumented, unexpected happens when people try to scroll a page? You just can't bind other functions to these keys. You never do this. Except for egoshooters and jump'n'runs and these ugly vertical scrolling pages nobody likes. This is none of this.

  5. Waldir Pimenta

    Why do the number hotkeys affect the cursor keys?

    I wasn't aware they did. I might be misunderstanding you, though.

    Why should it be intended that something completely different, undocumented, unexpected happens when people try to scroll a page? You just can't bind other functions to these keys. You never do this. Except for egoshooters and jump'n'runs and these ugly vertical scrolling pages nobody likes. This is none of this.

    Well, in a way this is an "untagged item" shooter game ;) but in all seriousness, yeah, I see your point. I suppose disabling the cursor keys and leaving the other shortcuts ones in place would make more sense. @magnusmanske what do you say?

  6. max

    As set out is the issue #131, I also did crazy edits due to this hotkeys: I pressed 8 times Alt-LeftArrow in order to come back to the wikidata-game main page... Proposition: either removing those, or put a reminder under the buttons to make this kind of confusion less likely.

  7. Solomon Ucko

    WHY THE HECK are there shortcut keys that:

    1. Perform actions that are not fully reversible
    2. Are completely undocumented within the app itself (the number keys are documented in the tooltips, but the arrow keys…)
    3. Coincide with a variety of existing browser shortcuts (e.g. scrolling, selecting text, navigating forwards and backwards, etc.)

    Arrow key shortcuts need to be made an off-by-default setting or completely removed ASAP before this causes any more damage.

  8. Log in to comment