Quickstatements csv importer can't handle external IDs

Issue #82 new
Remko de Keijzer created an issue

The quickstatements csv importer can't handle external IDs like P345 (IMDb id) I get the following result: ADD LAST ITEM IMDb ID [P345] {"type":"unknown","text":"nm6848183"}
When I use the v1 importer Like LAST P345 "nm6848183" I get a correct result. In some cases it's easier to use the CSV importer, so really want this fixed

Comments (6)

  1. Iván Hernández Cazorla

    It seems similar to what happens to me with some external identifiers but not all.

    Screenshot_20180302_212206.png

  2. Remko de Keijzer reporter

    Thanks for the screenshot @ivanhercaz. The issue seems to happen when the External ID contains non-digits (or combination of digits and non-digits) Just did a simple test. Input data:

    qid,P2536
    Q4115189,12345
    Q4115189,aa12345
    Q4115189,"aa12345"
    Q4115189,abcd
    Q4115189,"abcd"
    Q4115189,a-b
    Q4115189,"a-b"
    Q4115189,'Q4115189'
    Q4115189,"12345"
    Q4115189,'12345'
    Q4115189,12-34
    

    And this was the result: Knipsel.PNG So the issue is when the value isn't all digits. (And single quotes make it non-digit)

  3. Iván Hernández Cazorla

    Thank you, @mbch331! So, it should be fixed because the identifiers sometimes are composed of digits and non digit. I hope @magnusmanske knows how to fix it, because I like very much the new CSS file syntax for QuickStatements, it is very useful!

    Two days ago I posted a similar issue (#83) with external URLs.

  4. Iván Hernández Cazorla

    @lucaswerkmeister, in relation with #83, I also try enclosing the value in """ but it didn't work :/ I haven't tried QuickStatements for a long time, but I have to test if my issues was solved. Thank you for the link to the topic, I will watch it :)

  5. Log in to comment