Bitbucket cannot automatically merge this request.
The commits that make up this pull request have been removed.
Bitbucket cannot automatically merge this request due to conflicts.
Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:
git checkout master
git remote add paratron/mandrill-api-php https://bitbucket.org/paratron/mandrill-api-php.git
git fetch paratron/mandrill-api-php
git merge --no-ff -m 'Merged in paratron/mandrill-api-php (pull request #4)' remotes/paratron/mandrill-api-php/master
Might look as nitpicking, but my IDE constantly complains about me giving the wrong data type to the $mandrill->messages->send() method when passing an array (which is fine).
PHP never had structs, I don't know how that keyword landed there in the first place.
I absolutely agree with this.
I joined Bitbucket to vote for this. Please? :)
+1 :) I have the same OCD for IDE highlights
+1 for not type-hinting on a type that doesn't even exist!
You should change phpdoc for sendTemplate also.
+1 for change
stupid typehint, really
+1 I was actually about to fork and do this change myself.
+1 This ever going to get merged in?
I'm pretty astounded that Mandrill has almost no development work. We're probably going to switch to SendGrid or another similar provider; issues like this, literally a single doc word, not getting integrated for years is completely unacceptable.
Well, I switched to Mailgun years ago and can't be happier. Mandrill is dead.