Mismatch of track edit states?

Issue #189 closed
wthaemelt created an issue

Patch version 676511d9ba16. Windows 7.

The following procedure leads to a strange (wrong?) track range selection mode (can be reproduced!):

  • Use track with some routing points (big black squares) and some subpoints(small black squares, created with routing).
  • Click on track in map view.
  • Click on "Edit position ..." icon in track info window.
  • Cursor changes to "Move point" icon and toolbar on top of map view pops-up.
  • "Select range" icon in toolbar is active!
  • Click "Select range" icon.
  • Cursor changes to "Select range" icon!
  • Move mouse to subpoint of track and left click - nothing happens.
  • Move mouse to start point of track or another routing point and left click.
  • Move mouse to a new position on track.
  • Result: Track range between clicked and next routing point (even if mouse is positioned at subpoint) is shown as ugly green line (not normal range green!).
  • Click on end of green line (routing point).
  • Small window with "Delete" and "Calculate route" icons pops-up.

Is this a wanted track state/behavior?

Should the "Select range" toolbar icon be set to inactive after selection of the track "edit position" mode?

Should the "Move points" track state be removed when clicking the range selection icon?

Comments (9)

  1. kiozen

    Just keep in mind that subpoints are no real track points. And selection only affects real track points. It has been always like that. But before the patch sub-points were converted to real track points when saving the track. Now the information is preserved. Thus it's more likely you notice.

  2. Christian Eichler

    The only thing I noticed is the incorrect drawing of the subpoints on the "green" line: Instead of small dots, they are drawn as ordinary trackpoints. However, this weird drawing is not new - you can draw a track and do a range selection without saving to see this artifact in older versions of QMS.

    Should the "Select range" toolbar icon be set to inactive after selection of the track "edit position" mode?

    Should the "Move points" track state be removed when clicking the range selection icon?

    No, "Select range" is intended to be used to remove several trackpoints without leaving the "edit" mode.

  3. wthaemelt reporter

    Thanks for your explanations.

    If I'm not mistaken, then there is the following difference in range selection in a map view and in the way I can work with the selected range (my QMS version wasn't changed!):

    • Click on track and then on range select icon: now I can select a range of subpoints(!) and do something with them (hide/unhide them, copy them). Everything goes as I expect. And "unhide" option brings me back to the original track. I even can see the grey original track!

    • Click on track, click edit position icon and then click range select in toolbar at the top of the map view: no more chance to select a range of subpoints, I can only select a range limited by "true" trackpoints.

      After clicking at the endpoint of the range I get 2 icons (and not the ones I get in the previous point): "delete all points between first and last" and "recalculate". Clicking "delete" now deletes subpoints but only those between the last (true) trackpoint and its predecessor (true waypoint). All other highlighted subpoints in the selected range remain in the track. Reading the icon text I would expect that all subpoints (and, maybe, even true waypoints) in the selected range would be removed. And there seems to be another difference: in the previous case I can go back to the original track (unhide). In the given case I have only a chance to recalculate and this may lead to new subpoints (not the ones hidden).

      Thus, in this case a rather different behavior of the range selection and the operations linked to this mode.

    I don't have a problem to accept the described situations as features:

    • Range selection and handling:
      • first mode of operation: not in edit mode, range of subpoints, hide/unhide.
      • second mode of operation: in edit mode, range of true trackpoints (plus subpoints inbetween), delete and recalculate (re-route).
  4. Christian Eichler

    At this point, I understand your confusion.

    The short answer: Imho, your summary describes the mode of operation pretty accurately.

    The longer answer: The edit mode is intended to modify a track's trackpoints. Subpoints are - in contrast to ordinary trackpoints - not designed to be modified manually; they are kept as a result of the routing process and to simplify rerouting. Thus, manual modification (moving, deleting) of subpoints does not really make sense. If you need to modify subpoints, you will need to convert them to ordinary trackpoints (by using the filter convert track subpoints to points).

    Let's take it the other way round: Which behavior did you expect? Should both range selections result in identical "bubbles"? Is the differentiation between "hide points" and "delete points" reasonable?

    All other highlighted subpoints in the selected range remain in the track.

    Any trackpoints and subpoints within the selected range should be removed when clicking "delete". In my tests, this works well. Are you able to provide a screenshot of the track after deleting the selected range and/or the track you were using?

  5. wthaemelt reporter

    @Christian: I agree with almost all of your statements and do not have the intention to propose any conceptual changes.

    With your explanation I understand now what is going on. I add a series of snapshots to pinpoint what seems to be confusing:

    1. Track with 4 true trackpoints and a lot of Routino-added subpoints. Exercise: find the 2 intermediate trackpoints!
    2. Edit mode plus selected range. End points of range: true waypoints.
    3. Delete icon clicked: only subpoints between last 2 true waypoints deleted. I think it is this step where confusion starts: Carefully checking the trackpoints I understand now that all intermediate true(!) waypoints (2 of them) have been deleted. This is hard to find out! In particular, because by some unknown reason only part of the subpoints is deleted (maybe a better formulation could be: some of the subpoints are still displayed).
    4. New range selected.
    5. Recalculation clicked. Routino settings not changed! If you don't understand step 3, then you don't understand this step and you would expect that the straight line segment in the middle of the track and only this one would be re-routed. Obviously the new track is obtained from routing between original start and end points of track. Reason: Intermediate true waypoints used for routing were deleted.

    I think it is step 3 to which attention should be paid: If you have a dense sequence of track points, it is hard to distinguish true trackpoints and subpoints on the map. The picture would be much clearer if all subpoints in the selected range would be deleted. Is there any good reason to keep them in the map (in the track)?

    Do you see a way to reduce the described confusion?

    Attached you find the track I played with.

  6. wthaemelt reporter

    Sorry for the wrong Christian in the previous step! Bitbucket inserted this somehow automatically.

  7. Christian Eichler

    To your "3.": Oliver's commit 880e200 (yesterday) solves your issue with "not all subpoints are deleted" (at least it does on my system). This is/was clearly a bug. Try updating your version of QMS.

    Other things that should be fixed (imho, will take care in the upcoming days):

    • selected subpoints in edit mode should be drawn as subpoints
    • green selection line should not draw over bubbles

    Bitbucket inserts the users friendly name when prefixing with @, you have to use the user's "ID".

  8. wthaemelt reporter

    I switched to the latest QMS version. Now all troublesome subpoints have gone!

    Allow me to take this opportunity to thank you for the work you did on QMS in 2016 and to thank you for your permanent and constructive attention to the discussion of problems QMS users had raised in this year. With your help I personally learned to use QMS a lot better.

    I wish you a very Happy New Year. Hope you have a great time ahead in developing your software and working with the community.

  9. Log in to comment