Post Review failed or Patch not applied cleanly in Reviewboard when used with RhodeCode as the HG Server

Issue #346 wontfix
Vairavan Laxman created an issue


I tried to configure Reviewboard with my 'testuser' with password 'testpassword' as:

url: http://testuser:testpassword@localhost/hg/myrepo

When I do this and try to submit a review using TortoiseHG or using hg postreview, both of them are failing.

But when I change the URL in Reviewboard to :

url: http://localhost/hg/myrepo

My review is being submitted using the Diff files with both TortoiseHG and hg postreview. But when I click on View Diff, I'm getting the 'patch not applied cleanly' error and I'm not sure on what has to be done.

Another information is that, I was just using the hgweb.cgi and ReviewBoard was working fine with it. But after moving to Rhodecode, I got all the security that I had always wanted, but, ReviewBoard's View Diff alone is not working.

Few more information pertaining to the same issue are that when ReviewBoard is trying to apply the patch for "View Diff", I'm getting the default login page of RhodeCode, ie. the index page with login dialog(I found this out after checking the failed patches in Reviewboard). I did provide the Username and Password in ReviewBoard for RhodeCode's authentication, but somehow, its redirecting me to the login page of RhodeCode and thats why the Patch is not being applied cleanly. The friends at ReviewBoard group mentioned that Reviewboard is not able to get the "raw file url", but I'm not sure how to go about that.

Please advice. Also, please do let me know if you need any further information, I will definitely put them up as I do not know what all information you would be needing.

Thanks, Vairav

Comments (3)

  1. Vairavan Laxman reporter

    Thank you so much for the information Marcin. I had been caught up for a while at work and since now I'm free, I'm going to take a look at it and will get back to you if I make any progress.

    Thanks again, Vairav

  2. Marcin Kuzminski repo owner

    It's too old now, and those kind of issues are always related to review-board cannot auth into rhodecode.

  3. Log in to comment