Incorrect graph in Git changelog

Issue #470 resolved
Justin Holewinski created an issue

When viewing the changelog for a Git repository, the left-side graph does not appear to handle non-linear history. Specifically, if I have "master" and "my-branch" branches which diverge then are merged, the changelog will show the history of these branches as linearized.

For reproduction, I uploaded a simple repo to the demo site: http://demo.rhodecode.org/git-history-graph/changelog

Comments (8)

  1. Marcin Kuzminski repo owner

    implemented in beta branch now, but i'm not happy with performance of this, we will see later on if this stays.

  2. Justin Holewinski reporter

    If this gets pulled, then I would recommend not displaying the graph at all for Git. Otherwise, the graph is incorrect.

  3. Justin Holewinski reporter

    Right, I'm referring to if this change gets pulled. The old behavior produced graphs that were incorrect, so it would be best to just not display them without this fix.

    On second thought, is the confusion that I used the word "pulled"? I meant "removed from the repo" or "reverted" like in your original comment about the performance being too low. :)

  4. Marcin Kuzminski repo owner

    For now it'll be kept in beta, but for now i can see it doesn't really affect performance in noticeable way

  5. Log in to comment