Code Review For Groups Of Changesets

Issue #512 resolved
William Roush created an issue

Somewhat along the lines of code review and issue #511. I'm interested in chucking ReviewBoard for RhodeCode, however reviewing every changeset is a bit annoying.

In ReviewBoard, I can select changesets and submit them as one review, are there plans in the future to do this with RhodeCode?

Very minor priority being as it is duplicate behavior with ReviewBoard.

Comments (5)

  1. William Roush reporter

    Would this require each developer to fork a repo much like pull requests work on Github and Bitbucket (or have production/development repos and make pull requests into production)? Or can a pull request be made of arbitrary changesets on a single repo? (Ex: pull request on the previous 5 commits on develop, I know that doesn't really make sense as far as a "pull request" goes but aligns with how ReviewBoard can be used)

    Though the more I think about it the more maybe I should review our process at work to allow for a working fork and a main copy.

  2. Marcin Kuzminski repo owner

    Currently you can open pull request against forked repo, or the same repoo based on two tags,bookmarks, branches. The engine can also make the pull request based on two revisions, but this is not yet in UI. In later stage you will be able to cherry pick changesets from changlog using the checkboxes, and open pull request just for those changesets.

    My personal desired workflow at the end when this system is polished, is i myself open pull request for me, with my few chosen changesets, and review it aprove/decline and iterate over.

  3. William Roush reporter

    Currently you can open pull request against forked repo, or the same repoo based on two tags,bookmarks, branches.

    Ok, that's perfect for my use case (we'll be reviewing develop -> default requests)!

    The engine can also make the pull request based on two revisions, but this is not yet in UI. In later stage you will be able to checrry pick changesets from changlog using the checkboxes, and open pull request just for those changesets.

    That'll make ReviewBoard useless for us under all circumstances.

    Thanks for your time, and thanks for an awesome piece of software. :)

  4. Log in to comment