1. Marcin Kuzminski
  2. RhodeCode

Issues

Issue #599 resolved

Changelog & Compare Fork view presents raw HTML

Aras Pranckevičius
created an issue

Changelog & Compare Fork (1.4.4) seems to present raw HTML or some weird escaping. Examples:

  • commit msg containing "->" rendered as "->"
  • commit msg referencing other commit rendered as full HTML markup

See attached image.

The shortlog doesn't seem to have these issues

Comments (10)

  1. Aras Pranckevičius reporter

    Oh, the changelog view has exactly those two issues as well. Not the shortlog though.

    Seems to be new to 1.4.4 (could be 1.4.3 as well, we just upgraded to 1.4.4 from some older 1.4.x)

  2. Marcin Kuzminski repo owner

    Might be the case, i remember i seen some odd escaping issues when webhelpers library installed in system override the one in rhodecode virtualenv, can you post the list of libraries with versions from the admin -> settings under System Info and Packages section ?

    Here are for reference the one from demo:

    amqplib 1.0.2
    anyjson 0.3.3
    apt-xapian-index    0.41
    argparse    1.2.1
    Babel   0.9.6
    Beaker  1.6.4
    celery  2.2.10
    chardet 2.0.1
    command-not-found   0.1
    Cython  0.13
    decorator   3.3.3
    distribute  0.6.15
    docutils    0.8.1
    dulwich 0.8.5
    FormEncode  1.2.4
    git 1.7.4
    GnuPGInterface  0.3.2
    grin    1.2.1
    kombu   1.5.1
    Mako    0.7.2
    Markdown    2.1.1
    MarkupSafe  0.15
    meliae  0.3.0.final.0
    mercurial   2.3.2
    mock    1.0.0
    nose    1.2.1
    numpy   1.5.1
    Paste   1.7.3.1
    PasteDeploy 1.3.3
    PasteScript 1.7.3
    pip 0.7.2
    psycopg2    2.4.5
    py-bcrypt   0.2
    pycrypto    2.1.0
    pycryptopp  0.5.29
    Pygments    1.5
    Pylons  1.0
    pyparsing   1.5.6
    Python  2.7
    python-apt  0.7.100.3ubuntu6.1
    python-dateutil 1.5
    python-debian   0.1.18ubuntu2
    repoze.lru  0.6
    RhodeCode   1.4.5b
    Routes  1.13
    setuptools  0.6c11
    simplejson  2.5.2
    SQLAlchemy  0.7.8
    Tempita 0.5.1
    ufw 0.30.1-1ubuntu1
    virtualenv  1.4.9
    waitress    0.8.1
    WebError    0.10.3
    WebHelpers  1.3
    WebOb   1.0.8
    WebTest 1.4.0
    Whoosh  2.4.1
    wsgiref 0.1.2
    
  3. Martin Nielsen

    Just listing our libs:


    amqplib 1.0.2

    anyjson 0.3.3

    Babel 0.9.6

    Beaker 1.6.4

    celery 2.2.10

    chardet 1.0.1

    decorator 3.3.3

    distribute 0.6.28

    docutils 0.8.1

    dulwich 0.8.5

    FormEncode 1.2.4

    git 0.0

    importlib 1.0.2

    iotop 0.4

    kombu 1.5.1

    lxml 2.2.8

    Mako 0.7.2

    Markdown 2.1.1

    MarkupSafe 0.15

    mercurial 2.3.2

    mock 1.0.0

    nose 1.2.1

    Paste 1.7.5.1

    PasteDeploy 1.5.0

    PasteScript 1.7.5

    PIL 1.1.7

    pip 0.7.2

    psycopg2 2.4.2

    py-bcrypt 0.2

    Pygments 1.5

    Pylons 1.0

    pyparsing 1.5.6

    Python 2.6

    python-apt 0.7.100.1-squeeze1

    python-dateutil 1.5

    python-ldap 2.4.4

    reportbug 4.12.6

    repoze.lru 0.6

    RhodeCode 1.4.4

    Routes 1.13

    setuptools 0.6c11

    simplejson 2.5.2

    SQLAlchemy 0.7.8

    Tempita 0.5.1

    unittest2 0.5.1

    vcs 0.2.2

    virtualenv 1.4.9

    waitress 0.8.1

    WebError 0.10.3

    WebHelpers 1.3

    WebOb 1.0.8

    WebTest 1.4.0

    Whoosh 2.4.1

    wsgiref 0.1.2

  4. Marcin Kuzminski repo owner

    Looks fine for me. One thing is maybe trying to clean data/templates folder from your rhodecode installation. Also interesting to check is turning on globalsitepackages in this virtualenv, still i have a feeling that old webhelpers library is the issue here

  5. Log in to comment