1. Marcin Kuzminski
  2. RhodeCode
  3. Issues

Issues

Issue #629 new

RSS Feed of the Journal Reports Incorrect Times

Anonymous created an issue

Looking at the journal, it reports the correct times of events, however the RSS feeds do not report the same time.

Comments (7)

  1. Aaron Graddy

    I noticed the same issue. When I pull up what the rss is reporting, it says

    <lastBuildDate>Mon, 17 Dec 2012 11:51:39 -0000</lastBuildDate>

    This was at actually done at 11:51:39 -0600...so I'd say the feed, not the reader, is reporting the offset wrong.

  2. Marcin Kuzminski repo owner

    Just checked the RSS/ATOM feedgenerators code, and it looks like if you pass in a datetime objects without the tzinfo, it creates a data in format date.strftime('%a, %d %b %Y %H:%M:%S -0000'), but IMHO that is correct the date, it's the date of server when the action was stored.

  3. Tavis Elliott

    I have noticed that the RSS feed appears to report the date the commit was made to mercurial, not the date it was pushed up to RhodeCode.

    I would much rather have the push date, as we will frequently have commits sit around for a while on developer machines while they are tested, or we gain approval to push.

    Very annoying to see a new unread RSS item, and have to scroll over a month of commits to find it.

  4. Tavis Elliott

    Seems fine to me to have both dates ... I would just prever the "Date" used by the news reader for ordering purposes is the date the change was pushed. :)

    I just had an example single push from an engineer which contained 4 commits. The commits were done this morning at 9:44, 10:03, 11:14, and 11:15 AM. (The "<user> committed on <DATE>) line in the RSS message states that correctly. However, the dates reported by the news reader are (respectively) 01:44 AM, 02:03 AM, 03:14 AM, 03:15 AM. (I'm using Thunderbird)

    Looking at the incoming raw data for the RSS, the date is: "Wed, 23 Jan 2013 10:03:46 -0000". We are in the Pacific time zone, so I don't think that's correct. Thunderbird looks at that and says "Oh, that's UTC, I'm going to convert it to Pacific for you". The date should be "Wed, 23 Jan 2013 10:03:46 -8000". Is there something we've misconfigured for this to be the case?

  5. Log in to comment