Code review

Issue #71 resolved
Marcin Kuzminski repo owner created an issue

That's a great feature. Really would like to implement this good. Githubs example is a good one. the hgrevew plugin is also a good option

Comments (33)

  1. Marcin Kuzminski reporter

    The problem with reviewboard is it's a large django app, and i think it would be bad idea to attach it to rhodecode, hg-review on the other hand provides a nice api which would easily integrate with rhodecode, but only for mercurial.

    I need to rethink the possible solutions...

  2. Marc Sanfaçon

    We are using ReviewBoard. It can easily use Rhodecode as the source repository.

    Give it a try!

  3. David Stockton

    @striker69: We are using ReviewBoard with SVN successfully and I've added many of our repos from RhodeCode into it. We are running into issues where the majority of the uploaded patch files make ReviewBoard blow up. Have you run into this or was there anything special you had to do to get ReviewBoard and RhodeCode to play nicely together?

    Thanks, David

  4. Marc Sanfaçon

    @dstockto We have never had any issues with Rhodecode & Reviewboard. We use it with the TortoiseHG integration. The only thing, is that you must push the modifications to the server prior to creating the review. But that works well.

  5. Former user Account Deleted

    @striker69 - We are using a "golden" central repo which doesn't receive the changesets until they've passed through QA successfully. We've got review board set up against the golden repo. The developers work based on a "stable" bookmark that exists in golden and moves along as the changes get through QA. Without exception, diffs or "hg postreview" when Review Board is configured to use the Rhodecode URL fail with a stack trace about being unable to apply the diff.

    We did find a way around it though. We also set up hgwebdir.cgi (the one that comes with mercurial) to serve up all the same repos Rhodecode does (read-only though). When we point review board to the hgwebdir URLs the diffs work whether it's postreview or a diff. That would lead me to believe that the way Review Board interacts with the repos it gets a slightly different response or something that Review Board cannot deal with from Rhodecode that it doesn't get from hgwebdir.

  6. Marcin Kuzminski reporter

    @dstockto that sound like a bug for me, the raw-diff pages suppose to be 1:1 with hgweb format, maybe we're missing something here ?

  7. Marc Sanfaçon

    @dstockto Do you have more information on the error - stack trace, logs, others? May be this could help to pinpoint the problem.

  8. David Stockton

    @striker69 - I will set up a review board pointing to rhode code on Monday and post the stack trace here then.

  9. Marcin Kuzminski reporter

    @striker69 @dstockto you should also test drive code review in 1.3 beta :), i need some feedback.

  10. David Stockton

    Here's the stack trace I see when I try to do a view diff when I've submitted a patch/diff for a Review Board that is configured to point to Rhodecode:

    The patch to 'feature20.txt' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.bV0KsF' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.bV0KsF/tmpVtBTej Hunk #1 FAILED at 2. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.bV0KsF/tmpVtBTej-new.rej

    Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/reviewboard/diffviewer/", line 151, in view_diff interdiffset, highlighting, True) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/reviewboard/diffviewer/", line 1071, in get_diff_files large_data=True) File "/usr/lib/python2.4/site-packages/Djblets-0.6.13-py2.4.egg/djblets/util/", line 156, in cache_memoize data = lookup_callable() File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/reviewboard/diffviewer/", line 1070, in <lambda> enable_syntax_highlighting)), File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/reviewboard/diffviewer/", line 552, in get_chunks new = get_patched_file(old, filediff) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/reviewboard/diffviewer/", line 374, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/reviewboard/diffviewer/", line 239, in patch raise Exception(_("The patch to '%s' didn't apply cleanly. The temporary " + Exception: The patch to 'feature20.txt' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.bV0KsF' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.bV0KsF/tmpVtBTej Hunk #1 FAILED at 2. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.bV0KsF/tmpVtBTej-new.rej

  11. David Stockton

    @marcinkuzminski @stryker69 - Let me know if you need something else from this. The stack trace above is from posting a diff against a review board with the repo set up pointed to Rhodecode.

  12. Former user Account Deleted

    Hi, I'm also facing the same problem as dstockto. It would be great if you could let us all know on what has to be done to fix this issue.

    Thanks, Vairav

  13. Vairavan Laxman
    • changed status to open
    • marked as bug

    I tried to configure Reviewboard with my 'testuser' with password 'testpassword' as:

    url: http://testuser:testpassword@localhost/hg/myrepo

    When I do this and try to submit a review using TortoiseHG or using hg postreview, both of them are failing.

    But when I change the URL in Reviewboard to :

    url: http://localhost/hg/myrepo

    My review is being submitted using the Diff files using both TortoiseHG and hg postreview. But when I click on View Diff, I'm getting the 'patch not applied cleanly' error and I'm not sure on what has to be done. Another information is that, I've not pushed my changes to the server yet. I dint push it because, earlier to RhodeCode, I was just using the hgweb.cgi and ReviewBoard was working fine with it. But after moving to Rhodecode, I got all the security that I had always wanted but, ReviewBoard's View Diff alone is not working.

    Please advice. Also, please do let me know if you need any further information, I will definitely put them up as I do not know what all information you would be needing.

    Thanks, Vairav

  14. Marcin Kuzminski reporter

    Please post original diff generated (that used to work fine) and the same diff from rhodecode, please post them as original filenames, i'll compare and see what can be the cause.

  15. Vairavan Laxman

    Thank you Marcin, I'm still facing the same problem. I will open a new issue for the same.

    Thanks again Marcin.

    Regards, Vairav

  16. Vadim Kotov

    Whats about notifications for comments? You've said there will be a separate task for that, where could I find it?

  17. Log in to comment