Diff is incorrect in RSS feed with XML (and other things)

Issue #750 new
Tavis Elliott created an issue

We have some XML files (and javascript/css) in our Mercurial repository under RhodeCode. Now that the simply wonderful ability to show diffs in the RSS feed is in place, we found an issue. Consider the following, the diff section of the RSS source:

<pre>Adding reference to source files.

--- a/.idea/libraries/gwt_incubator_2_0_1.xml   Tue Jan 29 20:58:22 2013 -0800
+++ b/.idea/libraries/gwt_incubator_2_0_1.xml   Tue Jan 29 00:55:47 2013 -0800
@@ -4,6 +4,8 @@
       <root url="jar://$USER_HOME$/.gradle/caches/artifacts-14/filestore/com.google.gwt/gwt-incubator/2.0.1/jar/c9495634f0627d0b4de0d78a50a3aefebf67f8c/gwt-incubator-2.0.1.jar!/" />
     <JAVADOC />
-    <SOURCES />
+    <SOURCES>
+      <root url="jar://$USER_HOME$/.gradle/caches/artifacts-14/filestore/com.google.gwt/gwt-incubator/2.0.1/jar/c9495634f0627d0b4de0d78a50a3aefebf67f8c/gwt-incubator-2.0.1.jar!/" />
+    </SOURCES>
\ No newline at end of file

The RSS item for that shows up in Thunderbird like this:

 M .idea/libraries/gwt_incubator_2_0_1.xml (3 lines added, 1 lines removed)

diff --git a/.idea/libraries/gwt_incubator_2_0_1.xml b/.idea/libraries/gwt_incubator_2_0_1.xml
--- a/.idea/libraries/gwt_incubator_2_0_1.xml
+++ b/.idea/libraries/gwt_incubator_2_0_1.xml
@@ -4,6 +4,8 @@


Comments (9)

  1. Tavis Elliott reporter
    • edited description

    [edit] Hmm there are matching <pre>, perhaps those need to be <code>, or have <code> in addition? I'll see if I can test.

  2. Jay Gindin

    Any chance this will get looked at for the next point release? We must have a lot of code that triggers this bug.

    (I took a cursory glance at the code, and wasn't sure what part of the code is responsible for the RSS feeds.)

  3. Marcin Kuzminski repo owner

    i was waiting for the feedback if <code> fixes it, but for me it looks like a bug in Thunderbird, not RhodeCode

  4. Tavis Elliott reporter

    I was unable to complete the test, sorry. When I modified the python and restarted the server the entire world blew up and the server would not start (I believe it was unrelated to my change, but I was unwilling to risk another outage).

    This is not only a problem with Thunderbird btw, Outlook has the same issue, which leads me to believe that <pre> is not enough, it needs to have <code>.

  5. Tavis Elliott reporter

    Yes, I found the appropriate location in the code. Like I said though, I changed that .py file and when I tried to restart the server it wouldn't come up for several minutes, with what looked like library linkage problems (I can't recall the details now). After restoring the files it still didn't come up, and I have no idea what actually made it start up. Do I need to do something after changing feed.py to get the server to start correctly?

  6. Marcin Kuzminski repo owner

    changing the source code and restarting is enought, it must have been broken before the change if it didn't start. I dont have an outlook, neither thunderbird to test this

  7. Log in to comment