empty kwargs on PULL_HOOK (rcextension)

Issue #775 resolved
Former user created an issue

I'm running rhodecode over wsgi on apache2

Since the upgrade to 1.5.3 my custom rcextension has no data on a pull hook. Tried to figure it out myself, but could not find the issue.

it seems that action_logger() is called correctly, so it maybe the data is in rc_extras?

Could easily be a enviroment issue, but i'm running out of options...

Comments (6)

  1. Marcin Kuzminski repo owner

    Did you put rc extension in the same place as your ini file after upgrade? I double checked that now and it works fine on all of our systems

    If it's getting callwd

  2. Frans van der Meer

    Jep,

    It gets called, but de args are not there.

    Could it be that the needed data is in rc_extras? https://bitbucket.org/marcinkuzminski/rhodecode/src/7174ee850baafb02e35da1ee281c31a06267d4aa/rhodecode/lib/hooks.py?at=beta#cl-167

    If so, I don't see how the data is send to the callback here https://bitbucket.org/marcinkuzminski/rhodecode/src/7174ee850baafb02e35da1ee281c31a06267d4aa/rhodecode/lib/hooks.py?at=beta#cl-197

    But I am not an experienced Python dev-er... so I could easily miss it.

  3. Marcin Kuzminski repo owner

    I found an issue with this, But I rewrote most parts of this in beta and i this should work now correctly !

    Cheers

    Marcin Kuzminski

    On Thu, Mar 14, 2013 at 12:59 AM, FransvanderMeer <

  4. Log in to comment