Allow repositories to be cloned from file path (with spaces)

Issue #785 resolved
Allen Goh created an issue

I have set up a mount to another server. It would be great if a repository could be cloned by entering the full path. i.e. "/mnt/another server/some repository"

Comments (3)

  1. Marcin Kuzminski repo owner

    I'm not sure about that one, it poses some security issues. Image you would have two instances running and be able to close other instance repos via direct access to fileserver, not to mention cloning repositories you don't have access to within the same server.

    Why you don't simply expose the new location via hgweb, and clone via http urls on localhost?

  2. Allen Goh reporter

    The problem is that our company's git "server" is a Windows server hosting the repositories as simple file shares... I'm hoping to install Rhodecode to show them all the cool features (access control, code browsing, full text search) and convince them to switch. At the moment, I can clone from a filesystem path provided there are no spaces in the path. Is it just a matter of adding quotes to the git command issued by the vcs wrapper?

  3. Marcin Kuzminski repo owner

    I have blocked this completely now in a new release. I feel it was a security issue that it was possible. You should either copy those repos you would like to connect to RhodeCode, or just point at this location so RhodeCode can import all repos inside there.

  4. Log in to comment