Pull request should update following changesets after reviewee committed again

Issue #864 resolved
alex yang created an issue

Hi Team,

I found the pull request works very differently with bitbucket and github.
For example, I created a pull request like pull_1 with 2 changesets c_1 and c_2.
Then my team leader reviewed my pull request and gave me some comments. I pushed a changeset c_3 with my code updated according to the review comments.

But the problem is that pull_1 doesn't include the new c_3 changeset? Then team leader can't review the change until I created a new pull request.

Is it by design of RhodeCode or a missing feature? I just tried bitbucket and github both support this scenario. The benefit is that you don't need to create multiple pull requests for a tiny change. Meanwhile you can maintain all conversation log in the same pull request.

What do you think? Looking forward to your opinions.

Alex Yang

here is the forum thread:

Comments (3)

  1. Marcin Kuzminski repo owner

    We now have solved this issue in 3.X series of RhodeCode.
    Firstly Pull requests are updatable and there's a smart invalidation system that detects changes of added/removed/rebased commits, and automatically invalidate voting, as well as can detect changes in files.

  2. Log in to comment