#102 Declined
Repository
Deleted repository
Branch
beta (6d7c464080c7)
Repository
marcinkuzminski/RhodeCode RhodeCode
Branch
beta

#784: switch to branch: handle slashes in branch names

Author
  1. Dennis Brakhane avatarDennis Brakhane
Reviewers
Description

This is a not-so-pretty, but effective patch to support branches with slashes in them.

The disadvantage of this approach is that we introduce an inconsistency: normally, you can bookmark the resulting URL after switching to a branch, but when the branch contains a slash, you can't. Well actually, you can, but you will bookmark the same changeset and not the head of the branch. But it's pretty obvious from the resulting URL, so it's no big deal IMO.

Another way to fix this bug would be to change the routing for the files URL.

Comments (2)

  1. Marcin Kuzminski repo owner

    I had the same idea for a quick fix, after you created the issue so i think it will be ok for now. Obvious fix would be to handle properly named branches with slashes, but that is more tricky. I will accept this PR but please remove changes to the .ini file. Thanks !

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.