1. Marcin Kuzminski
  2. RhodeCode
  3. Pull requests

Pull requests

#102 Declined
Deleted repository
beta (6d7c464080c7)

#784: switch to branch: handle slashes in branch names

  1. Dennis Brakhane

This is a not-so-pretty, but effective patch to support branches with slashes in them.

The disadvantage of this approach is that we introduce an inconsistency: normally, you can bookmark the resulting URL after switching to a branch, but when the branch contains a slash, you can't. Well actually, you can, but you will bookmark the same changeset and not the head of the branch. But it's pretty obvious from the resulting URL, so it's no big deal IMO.

Another way to fix this bug would be to change the routing for the files URL.

Comments (2)

  1. Marcin Kuzminski repo owner

    I had the same idea for a quick fix, after you created the issue so i think it will be ok for now. Obvious fix would be to handle properly named branches with slashes, but that is more tricky. I will accept this PR but please remove changes to the .ini file. Thanks !