1. Marcin Kuzminski
  2. RhodeCode

Pull requests

#90 Open
Repository
pjameson
Branch
beta
Repository
marcinkuzminski
Branch
beta

Added '@' as a valid character in a username

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

Author
  1. Philip Jameson
Reviewers
Description

Added '@' as a valid character so that usernames can be email addresses. Still only lets the '@' happen once, and never at the beginning of a username. This only really seemed to be a problem when on a user's profile and trying to update the user information.

Comments (2)

  1. Marcin Kuzminski repo owner

    Hmm i'm afraid that change is a too big thing and can break in a lot of places. There's a separate email address dedicated. What's the idea behind this pull request ?

  2. Philip Jameson author

    Well we actually use email addresses for our usernames. If you try to make any modifications on the user profile page (say, promoting someone to admin), then it re-submits the username (an email), and says it's invalid. Just an FYI, we're using LDAP for user auth, so that's how an email gets in there in the first place. Would it be preferable to maybe just not have it allow username changes if you're an ldap user?