1. Marcus von Appen
  2. py-sdl2
  3. Pull requests

Pull requests

#17 Open

Implement sdl2.ext.get_sdl_version()

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r versions https://bitbucket.org/techtonik/py-sdl2
hg merge versions
hg commit -m 'Merged in techtonik/py-sdl2/versions (pull request #17)'
  1. anatoly techtonik
No description

Comments (2)

  1. Marcus von Appen repo owner

    I do miss the extra functionality being provided by that wrapper. If it is about a tuple representation of the version, that could be provided on the SDL_version class level rather than adding a new function for it.

  2. anatoly techtonik author

    That was my original thought too, but I couldn't think of immediate solution how to make ctypes.Structure object also a tuple. It seems that you need methods both from Structure and tuple and I am not sure they won't overlap and that mixin with two parents is actually a safe choice for ctypes.

    Another reasons is that I like that SDL_* is 1:1 mapped to SDL2 API. I am afraid adding new user visible methods, because it will break the mapping (I like to think that I'll be able to port some critical parts of my Python prototype to C when performance will be an issue).