Bad minimum values reported when HdrHistorgramResetOnSnapshotReservoir lacks new data

[Mike Walch]

I started using HdrHistorgramResetOnSnapshotReservoir as my backing reservoir for a dropwizard metrics timer. It has been working great except I noticed bad minimum values being reported when the the reservoir has not received new data since its last report. I was able to reproduce the problem in a simple application (see the gist below for the code and results):

https://gist.github.com/mikewalch/0db42df7d275ed405ca9

It looks like this problem goes away if you upgrade the version of HdrHistogram that is currently being used by 1.1.0 from 2.1.6 to 2.1.8.

[Marshall Pierce]

Thanks for the report, and the repro! I'll look into it.

[Marshall Pierce]

I was unable to write a test that reproduced this issue, even when running your sample code (with the minor change of using a ConsoleReporter instead of CSV). However, I added a few tests anyway, and updated the HdrHistogram dependency. I'll release a new version with the updated dependency.

[Mike Walch]

Thanks for looking into it and updating the dependency! Are you planning on publishing the artifacts to maven central? It can be done from bintray... http://blog.bintray.com/2014/02/11/bintray-as-pain-free-gateway-to-maven-central/

[Marshall Pierce]

When I click the "Maven Central" tab, nothing happens... perhaps they're having UI issues. Anyway, I encourage you to use jcenter instead... it's a superset of Maven Central, and in my experience has a faster CDN front-end.

[Marshall Pierce]

I tried again, and it failed Sonatype's validation.

Last Sync Errors: Invalid POM: /org/mpierce/metrics/reservoir/hdrhistogram-metrics-reservoir/1.1.1/hdrhistogram-metrics-reservoir-1.1.1.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing Dropping existing partial staging repository.

It's not very interesting to me to spend my time fixing that stuff, so while you're welcome to submit a PR if you are sufficiently motivated, I'm going to stick with "just use jcenter and life is better for everyone". :)