Martijn The avatar Martijn The committed 13fa7e5 Merge

Merged in dlackty/nsurlconnectionvcr/fix-expectedContentLength (pull request #2)

Fix crash in [NSURLConnectionVCR connection:didReceiveData]

Comments (0)

Files changed (2)

NSURLConnectionVCR/NSURLConnectionVCR.m

 - (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)data {
     if (responseData == nil) {
         long long expectedContentLength = [response expectedContentLength];
-        responseData = [NSMutableData dataWithCapacity:expectedContentLength];
+        if (expectedContentLength > 0) {
+            responseData = [NSMutableData dataWithCapacity:expectedContentLength];
+        } else {
+            responseData = [NSMutableData data];
+        }
     }
     [responseData appendData:data];
     [realDelegate connection:connection didReceiveData:data];

NSURLConnectionVCRTests/NSURLConnectionVCRTests.m

 - (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)data {
     if (responseData == nil) {
         long long expectedContentLength = [response expectedContentLength];
-        responseData = [NSMutableData dataWithLength:expectedContentLength];
+        if (expectedContentLength > 0) {
+            responseData = [NSMutableData dataWithCapacity:expectedContentLength];
+        } else {
+            responseData = [NSMutableData data];
+        }
     }
-    [responseData appendData:data];  
+    [responseData appendData:data];
 }
 
 - (NSCachedURLResponse *)connection:(NSURLConnection *)connection willCacheResponse:(NSCachedURLResponse *)cachedResponse {
     isDone = YES;
 }
 
-@end
+@end
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.