#2 Merged
Repository
dlackty dlackty
Branch
fix-expectedContentLength
Repository
martijnthe martijnthe
Branch
master

Fix crash in [NSURLConnectionVCR connection:didReceiveData]

Author
  1. Richard Lee avatarRichard Lee
Reviewers
Description

In NSURLConnectionVCR.m #365 line, there's a code snippets as below.

 long long expectedContentLength = [response expectedContentLength];
 responseData = [NSMutableData dataWithCapacity:expectedContentLength];

where [response expectedContentLength] might return -1 as suggested by Cocoa official doc, which will cause a crash for [NSMutableData dataWithCapacity:expectedContentLength].

This should also close issue #1. Please help review, and let me know if there's any problem. Thanks!

Comments (1)

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.