masklinn avatar masklinn committed 2f65624

Force termination of phantomjs subprocess if the suite is done running or there was an error, don't wait for a timeout

Comments (0)

Files changed (1)

qunitsuite/suite.py

             })
         ], stdout=subprocess.PIPE)
 
-        while True:
-            line = phantom.stdout.readline()
-            if line:
-                if self.process(line, result):
-                    break
-            else:
-                time.sleep(0.1)
+        try:
+            while True:
+                line = phantom.stdout.readline()
+                if line:
+                    if self.process(line, result):
+                        break
+                else:
+                    time.sleep(0.1)
+        finally:
+            # If the phantomjs process hasn't quit, kill it
+            if phantom.poll() is None:
+                phantom.terminate()
 
     def process(self, line, result):
         args = json.loads(line)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.