Re-factor out "java" core classes

Matt Wagner avatarMatt Wagner created an issue

Things like Tamir.SharpSSH.java.String give me the creeps. They wrap and implicitly convert into C# classes, with no real added value. Also, need to look to re-factor out all of the crappy wrappers for IO streams.

Comments (7)

  1. Matt Wagner
    • changed status to open

    Ugh! The wrapped "Java" classes leak out, I really need to get rid of them since now when I declare a string I have to pick the right package... what a joke.

  2. TaoK

    Minor comment on the probable reasoning behind these Java wrapper classes, as it's not clear that you see any rationale for using them: I imagine the original author wanted to keep the whole library as close to its Java roots as possible, so that enhancements and bugfixes could be painlessly brought in to the C# version. By isolating .Net-to-Java differences in wrapper classes, the whole thing might have remained much more maintainable with regards to its JSch roots.

    That said, given that Jsch went on to be more-or-less consistently maintained for the next 5 years, and SharpSsh was abandoned, I can see how that goal might no longer be realistic anyway.

  3. Matt Wagner

    I'd be inclined to agree with you, particularly as I don't do much maintenance on the library at this point. I no longer use it at work, and my initial modifications were solely geared to that use-case.

  4. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.