Byron Clark avatar Byron Clark committed 7bfc149

Check for dbus errors on the critical operations.

Comments (0)

Files changed (3)

-- actually check for errors from udisks calls
 - declare dependency on python-dbus
 - handle dbus restart
 - properly daemonize
         if device.is_handleable() and not device.is_mounted():
             filesystem = str(device.id_type())
             options = []
-            device.mount(filesystem, options)
-            self.log.info('mounted device %s' % (device,))
+            try:
+                device.mount(filesystem, options)
+                self.log.info('mounted device %s' % (device,))
+            except dbus.exceptions.DBusException, dbus_err:
+                self.log.error('failed to mount device %s: %s' % (device,
+                                                                  dbus_err))
 
     def mount_present_devices(self):
         """Mount handleable devices that are already present."""

udiskie/umount.py

 
     logger = logging.getLogger('udiskie.umount.unmount_device')
     if device.is_handleable() and device.is_mounted():
-        logger.debug('unmounting device %s' % (device,))
-        device.unmount()
-        logger.info('unmounted device %s' % (device,))
+        try:
+            device.unmount()
+            logger.info('unmounted device %s' % (device,))
+        except dbus.exceptions.DBusException, dbus_err:
+            logger.error('failed to unmount device %s: %s' % (device,
+                                                              dbus_err))
     else:
         logger.debug('skipping unhandled device %s' % (device,))
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.