Matt Chaput avatar Matt Chaput committed 50e1704

Raise an error if the user passes a Decimal to a NUMERIC field that doesn't
have decimal_places specified.

Comments (0)

Files changed (2)

src/whoosh/fields.py

         dc = self.decimal_places
         if dc and isinstance(x, (string_type, Decimal)):
             x = Decimal(x) * (10 ** dc)
+        elif isinstance(x, Decimal):
+            raise TypeError("Can't index a Decimal object unless you specified "
+                            "decimal_places on the field")
 
         try:
             x = self.numtype(x)

tests/test_indexing.py

             assert paths == ["/a", "/b"]
 
 
+def test_index_decimals():
+    from decimal import Decimal
+
+    schema = fields.Schema(name=fields.KEYWORD(stored=True),
+                           num=fields.NUMERIC(int))
+    ix = RamStorage().create_index(schema)
+
+    with ix.writer() as w:
+        with pytest.raises(TypeError):
+            w.add_document(name=u("hello"), num=Decimal("3.2"))
+
+    schema = fields.Schema(name=fields.KEYWORD(stored=True),
+                           num=fields.NUMERIC(Decimal, decimal_places=5))
+    ix = RamStorage().create_index(schema)
+    with ix.writer() as w:
+        w.add_document(name=u("hello"), num=Decimal("3.2"))
+
+
+
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.