1. mdelagra
  2. mercurial-reviewboard
Issue #13 wontfix

Read 'outgoingrepo' from config

iproetel
created an issue

Allow users to specify the value of 'outgoingrepo' in the [reviewboard] section of the hgrc file.

Comments (3)

  1. mdelagra repo owner

    What are you trying to do? Currently the flags work like this:

    • postreview (post without a parent diff)
    • postreview -o (post a diff after calculating a parent diff to the default repository)
    • postreview -O <repo_name> (post a diff after calculating a parent diff to repository provided on command line)

    If you set the "outgoingrepo" in the config file per your patch, this would become:

    • postreview (post a diff after calculating a parent diff to repository provided in config file)
    • postreview -o (post a diff after calculating a parent diff to repository provided in config file)
    • postreview -O <repo_name> (post a diff after calculating a parent diff to repository provided on command line)

    This seems like a confusing change to the way the flags work. Isn't it more straightforward to simply use the existing -o flag?

  2. iproetel reporter

    I find it useful to configure as much as possible in my hgrc file since I always need a --outgoingrepo for certain repositories. So I want to force prostreview to always calculate a parent diff on those.

  3. Log in to comment