#8 Open
simoncross simoncross
mdelagra mdelagra

send submit_as parameter in _create_request using username credential

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r dev-submit-as https://bitbucket.org/simoncross/mercurial-reviewboard
hg merge dev-submit-as
hg commit -m 'Merged in simoncross/mercurial-reviewboard/dev-submit-as (pull request #8)'
  1. simoncross avatarsimoncross

Found that when requesting a new review from TortoiseHG, the review is not submitted as the logged in user.

This change uses the current value of the username credential for the 'submit_as' parameter in the API call.

Comments (0)

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.