Pull requests

#8 Open
Repository
simoncross
Branch
dev-submit-as
Repository
mdelagra
Branch
default

send submit_as parameter in _create_request using username credential

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r dev-submit-as https://bitbucket.org/simoncross/mercurial-reviewboard
hg merge dev-submit-as
hg commit -m 'Merged in simoncross/mercurial-reviewboard/dev-submit-as (pull request #8)'
Author
  1. simoncross
Reviewers
Description

Found that when requesting a new review from TortoiseHG, the review is not submitted as the logged in user.

This change uses the current value of the username credential for the 'submit_as' parameter in the API call.

  • Learn about pull requests

Comments (0)