MBS-7576: Added relationships of the wrong cardinality are invisible
mwiencek
Branch: mwiencek/musicbrainz-server:mbs-7576
mwiencek/musicbrainz-server:mbs-7576
Branch: metabrainz/musicbrainz-server:beta
metabrainz/musicbrainz-server:beta
Merged
#970 · Created  · Last updated
Description
As it turns out, the link type <select> doesn't filter out options with bad cardinalities, so you can still add relationships from the "many" side. But after you add them, they're not displayed, because well that was the point.
At first I was thinking we should filter the link type options, but I imagine people would complain, so I haven't done that. There's still a danger of adding duplicates because they can't see the other relationships of that link type, but maybe it won't be a huge problem in practice (if it is we'll have to do something).
But even if we do hide certain link types, we should still display relationships that were added or modified in any way, so the user can see what they're submitting. So that's all this patch does.
chirlu also brought up a good point about link types that have the same entitiy types but different cardinalities on each side; since the relationship editor dialog lets you change the direction of the relationship, it probably actually hides it after doing that (without this patch).
As it turns out, the link type <select> doesn't filter out options with bad cardinalities, so you can still add relationships from the "many" side. But after you add them, they're not displayed, because well that was the point.
At first I was thinking we should filter the link type options, but I imagine people would complain, so I haven't done that. There's still a danger of adding duplicates because they can't see the other relationships of that link type, but maybe it won't be a huge problem in practice (if it is we'll have to do something).
But even if we do hide certain link types, we should still display relationships that were added or modified in any way, so the user can see what they're submitting. So that's all this patch does.
chirlu also brought up a good point about link types that have the same entitiy types but different cardinalities on each side; since the relationship editor dialog lets you change the direction of the relationship, it probably actually hides it after doing that (without this patch).