#45 Declined
Repository
JonnyJD
Branch
preflight
Repository
metabrainz
Branch
beta
Author
  1. Johannes Dewender
Reviewers
Description

See: http://tickets.musicbrainz.org/browse/MBS-6033

This basically implements this flowchart: http://www.html5rocks.com/static/images/cors_server_flowchart.png

The complete spec is http://www.w3.org/TR/cors/#resource-preflight-requests

Credentials/submissions are still not allowed.

  • Issues MBS-6033

Comments (4)

  1. Johannes Dewender author

    After a chat with @warp on IRC I will implement answering OPTIONS requests (MBS-6072) that also includes MBS-6033.

    I will use this branch as a starting point.

    Implementation as a Plack::Middleware module is in general possible, but it might be easier for now to just create an Allow.pm role and merge CORS.pm there. There is no pre-made Middleware module that works with both CORS and "normal" OPTIONS requests.

  2. ocharles

    This review appears to be stuck. Could this be discarded until you have a new review ready?

    1. Johannes Dewender author

      Done. I will resubmit when the other patch is done. Needs a bit more consideration and possibly tests. So not a "quick fix" like this one.