Add API key and fix cache keyword

#53 Open
Repository
jvansant
Branch
default
Repository
metapub
Branch
default

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/jvansant/metapub
hg merge c23332e00d9f
hg commit -m 'Merged in jvansant/metapub (pull request #53)'
Author
  1. jvansan
Reviewers
Description

Added NCBI API key support to PubMedFetcher. Also fixed cache_path bug. See Issue #19

Comments (5)

  1. Naomi Most

    No worries at all. Thanks for the contribution.

    Is there a way we can add a test (in /tests) around the API key feature?

    Sorry for delay in response, I was celebrating my birthday. 🙂

  2. jvansan author

    Sorry for the delay here, I completely missed the notification.

    I can add tests, but I’m not sure I’m allowed to publish an API key?

    I’ll look into it, but do you have any thoughts on how you’d like to get around this?

    1. Naomi Most

      Yeah – I would just make a test that uses a conditional skip if the API key isn’t set. (Bonus points for outputting a message that says something along the lines of “go set your API key if you plan on using that”.)

  3. Naomi Most

    Also – my apologies but in merging some previous pull requests it looks like some similar changes were made to the eutils usage, so now there are conflicts in your pull request. 😕