Build fails on Linux

[Simone Scanzoni]

Hello Matt, I tried to build commit 51c1cc7a8385fcb8daf5e60564e76e0051a07605 in my Gentoo without success.

The result is this.

Why did you move the repository here?

Thank you again for your work on this great project! :)

[Matt Feemster]

I have begun using some C++14 features, among them is make_unique. So be sure to upgrade your gcc version. Let me know if that fixes it.

I emailed a few people that I was moving the repo, but realized I didn't have your email, so I'm sorry about the surprise.

I moved it because gihub feels startuppy, whereas bitbucket feels more enterprisey, and I prefer the latter.

Glad you are enjoying it! Be sure to check the website, fractorium.com

[Matt Feemster]

If you already have a newer compiler, and it still doesn't build, can you try qualifying make_unique with std::

I really doubt that's the problem, but it might be worth trying just as a last attempt to fix it.

[Simone Scanzoni]

Sorry for not replying before, I missed the email from Bitbucket. I've been using GCC 4.9.3, but I could build and try version 5.3.0, I'll let you know, thanks!

[Simone Scanzoni]

I tried GCC 5.4.0 but it didn't work, even qualifying make_unique with std:: https://bpaste.net/show/843cba7a7c83 GCC 6 isn't yet in the main repository for Gentoo, so it would take some effort to try it for me. What version of GCC did you use?

[Matt Feemster]

Hmm, g++ -v gives me: gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04)

Seems really weird. Can you write a very small program making use of make_unique and see if it builds? Something like:

#include <memory>
using namespace std;

int main(int argc, char** argv)
{
    auto unq = make_unique<int>(123);
}

[Simone Scanzoni]

That doesn't link here, but I was able to build fractorium so I think I found the culprit.

qmake when building the Makefiles uses the value of the variable QMAKE_CXXFLAGS_GNUCXX11 found in /usr/lib64/qt5/mkspecs/common/g++-base.conf (included from -spec linux-g++-64 or by default) and puts it after -std=c++14. Since the last option specified is the one used it sets the wrong standard: gnu++0x.

I tried changing that variable to gnu++14 and fractorium built fine, but I can't keep it like that because it's obviously wrong, qmake should use QMAKE_CXXFLAGS_GNUCXX14 or QMAKE_CXXFLAGS_CXX14 instead.

I'm using Qt 5.6.0.

[Matt Feemster]

Fantastic find!

[Naranath Branthan]

@mfeemster Haha, "moved away because it feels more enterprisey", nice one, even if it "somehow" just smells more fecesbooky to me here XD

[Matt Feemster]

Build works with proper flags using C++14.