shaib avatar shaib committed 46026c6

Fix bugs in test fix
forgot to allow null instead of a default,
left an extra argument for command,
messed up transactions

Comments (0)

Files changed (1)

south/tests/db.py

             ('eggs', models.IntegerField()),
         ])
         # Change spam default
-        db.alter_column("test_altercd", "spam", models.CharField(max_length=30, default="loof"))
+        db.alter_column("test_altercd", "spam", models.CharField(max_length=30, default="loof", null=True))
         # Assert the default is not in the database
         db.execute("INSERT INTO test_altercd (eggs) values (12)")
         null = db.execute("SELECT spam FROM test_altercd")[0][0]
             statement = "insert into test_datetime_def (col0,%s) values (null,%%s,%%s)" % cols
             self.assertRaises(
                 IntegrityError,
-                db.execute, statement, [None, end_of_world, end_of_world]
+                db.execute, statement, [end_of_world, end_of_world]
             )
             db.rollback_transaction()
         
+        db.start_transaction() # To preserve the sanity and semantics of this test class
+        
     def test_add_unique_fk(self):
         """
         Test adding a ForeignKey with unique=True or a OneToOneField
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.