#6 Merged
Repository
pquentin
Branch
default
Repository
micktwomey
Branch
default
Author
  1. Quentin Pradet
Reviewers
Description

This does not appear to be really useful for pyiso8601, but adds noise to all project using this. I had to disable debug logging on pyiso8601 on three projects of mine, and there are at least two public bugs about this:

This pull request just removes everything, but something more subtle can be done too, I guess, like disabling debug logging by default.

Comments (4)

  1. Michael Twomey repo owner

    I'm slightly on the fence about this one. Strictly speaking the log4j pattern encourages libraries to aggressively use the DEBUG level and defer policy decisions to the consumer of the library, in practice there's a sort of "logging level" creep where a lot of projects wind up logging to DEBUG, which makes the pattern here annoying.

    As a bonus even with the deferred formatting pattern there's a performance impact too.

    I think on balance the logging doesn't add much and leads to problems for some consuming projects, so I'm going to merge this change.

  2. Jakub Stasiak

    There's significant performance difference between 0.1.10 and 0.1.11 when the library is used an environment controlled by nose (which captures all logging module logs):

    Just tested this in my test environment (times per iso860.parse_date call):

    • 0.1.10 - ~1200us
    • 0.1.11 - ~60us

    I believe it's thanks to the author of this patch :)