McObot does not relay messages only containing spaces to ingame.

[Anna Bakker]

Servertime: Wed 30 Sep 20:29:23 BST 2015

Messages sent in IRC that only contain spaces do not get sent to ingame.

[Riot]

Don't see how that is a bug

[Anna Bakker]

This also includes kick messages where the kick reason is spaces. Though that doesn't happen often

[Riot]

Those should be unrelated issues. Refusing to send empty player messages is a valid spam reduction feature, not recognising empty kick messages is a bug though.

[Anna Bakker]

These are related issues as ircbase has:

if msg != None and len(msg.split()) <= 0:
  return

So this stops an empty privmsg from being relayed. Though msg in a kick would be the kick reason, so a kick with just spaces as the reason is also not relayed.

[Riot]

That doesn't really make sense here though, because that should only apply to things sent to IRC. In which case there's no reason for it to be empty, if we're sending a message about a kick then there's going to be other verbal content.

[Anna Bakker]

I believe the msg is only relating to the actual message of a PRIVMSG or in this case a KICK. Other information like that it's a kick is stored as command, channel and user being kicked would be arguments and the person kicking would be the sender.

I don't think anything like the person being kicked is in the msg.

[Riot]

So is this filtering messages going in to the bot before processing? We shouldn't do that, I agree. But it makes sense to discard and not send blank messages.