Commits

Author Commit Message Labels Comments Date
Minux
cmd/internal/ld, runtime, runtime/cgo, syscall: code review changes
Branches
ios64-new
Minux
Merge branch 'master' into ios64-new
Branches
ios64-new
Matthew Dempsky
compress/flate: add optional runtime sanity checks This code's test coverage is ad hoc at best, and it's easy to make changes that accidentally regress invariants. This CL adds a "sanity" constant that can be changed to "true" during development to add extra runtime checking that the Huffman decoder tables are sane. Change-Id: I0d0ca53ad7c9566be18046d9b255e1a30059f28b Reviewed-on: https://go-review.googlesource.com/8974 Reviewed-by: Nigel Tao <n…
Branches
2 branches
Matthew Dempsky
compress/flate: reject invalid Huffman encoding sequences When decoding Huffman codes, if an invalid bit sequence is discovered, reject the input instead of treating it as a 0-length code. Fixes #10426. Change-Id: Ie2f1a3a718afd7c6bee73a67480d4b84936c21c9 Reviewed-on: https://go-review.googlesource.com/8893 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Nigel Tao <nigeltao@golang.org>
Branches
2 branches
Dave Day
reflect: add FuncOf function This also involves adding functions to typelinks along with a minor change to ensure they are sorted correctly. Change-Id: I054a79b6498a634cbccce17579f52c299733c2cf Reviewed-on: https://go-review.googlesource.com/1996 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Nigel Tao
image: spell coordinate consistently, without the hyphen. Change-Id: I211c0d33dc292c6a703d788f6d4d286107bcb6b0 Reviewed-on: https://go-review.googlesource.com/8906 Reviewed-by: Rob Pike <r@golang.org>
Branches
2 branches
Mikio Hara
net: fix TestDialGoogle with -ipv6 when CGO_ENABLED=0 Under some dial tests that require external network connectivity, we must prevent application traffic but must not interfere with control plane traffic such as DNS message exchange. But test helper function disableSocketConnect prevents both application and control plane traffic unconditionally and makes some dial tests with -ipv6 fail when CGO_ENABLED=0. This change makes disableSocketConnect ta…
Branches
2 branches
Michael Hudson-Doyle
cmd/6l: call runtime.addmoduledata from .init_array Change-Id: I09e84161d106960a69972f5fc845a1e40c28e58f Reviewed-on: https://go-review.googlesource.com/8331 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Michael Hudson-Doyle
cmd/go: support -buildmode=shared You can now do 'go install -buildmode=shared std' and get yourself a nice (33 meg) libstd.so (which is not useful until there is -linkshared support as well, of course). Change-Id: Ie9b7e7f72abc7d369a6e3ecc98903a9d197bd6e6 Reviewed-on: https://go-review.googlesource.com/8300 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor …
Branches
2 branches
Ian Lance Taylor
internal/syscall: move to unix subdirectory Move the single file from internal/syscall to internal/syscall/unix, to match the golang.org/x/sys layout. Change-Id: I2fb2832b4cb22efc7666bd276f5401ac3e73dc40 Reviewed-on: https://go-review.googlesource.com/8972 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Rob Pike <r@golang.org>
Branches
2 branches
David Crawshaw
cmd/test: require external linking for c-archive Change-Id: I9ceceb29291ea9f5d7b675dfabd665c5e3618471 Reviewed-on: https://go-review.googlesource.com/8955 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Michael Hudson-Doyle
go/build: support -installsuffix with gccgo Fixes #10449 Change-Id: I1dc2d0213e6a46f3609222d5460c1a54081e2471 Reviewed-on: https://go-review.googlesource.com/8931 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Michael Hudson-Doyle
cmd/go, go/build: add build.Package.PkgTargetRoot This is $GOPATH/pkg/linux_amd64 or similar. cmd/go already had a grotty calculation of this and I need to add another one for -buildmode=shared. Change-Id: Ied28c9b7cce671da8d45920e124a3e0c2501258a Reviewed-on: https://go-review.googlesource.com/8930 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Branches
2 branches
Michael Hudson-Doyle
cmd/internal/ld: allow -r to override rpath when -linkshared Including having -r "" preventing rpath from being set at all. Change-Id: Ib40d7bf93a6e9ef21985c4a05b5703e4fbd1cd1b Reviewed-on: https://go-review.googlesource.com/8806 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Josh Bleecher Snyder
cmd/6g, runtime: improve duffzero throughput It is faster to execute MOVQ AX,(DI) MOVQ AX,8(DI) MOVQ AX,16(DI) MOVQ AX,24(DI) ADDQ $32,DI than STOSQ STOSQ STOSQ STOSQ However, in order to be able to jump into the middle of a block of MOVQs, the call site needs to pre-adjust DI. If we're clearing a small area, the cost of that DI pre-adjustment isn't repaid. This CL switches the DUFFZERO implementation to use a hybrid strategy,…
Branches
2 branches
Josh Bleecher Snyder
cmd/internal/gc, cmd/gc: move Reg from Val to Node Val is used to hold constant values. Reg was the odd duck out. Generated using eg. No functional changes. Passes toolstash -cmp. Change-Id: Ic1de769a1f92bb02e09a4428d998b716f307e2f6 Reviewed-on: https://go-review.googlesource.com/8912 Reviewed-by: Russ Cox <rsc@golang.org>
Branches
2 branches
Michael Hudson-Doyle
runtime: merge slice and sliceStruct By removing type slice, renaming type sliceStruct to type slice and whacking until it compiles. Has a pleasing net reduction of conversions. Fixes #10188 Change-Id: I77202b8df637185b632fd7875a1fdd8d52c7a83c Reviewed-on: https://go-review.googlesource.com/8770 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.o…
Branches
2 branches
Michael Hudson-Doyle
cmd/dist: fix bootstrapping with gccgo on 386 We forgot to add the !gccgo tag to cpuid_386.s. Change-Id: I2de2ed92ac9686c9365cb37cd29121fa98c2bf37 Reviewed-on: https://go-review.googlesource.com/8960 Reviewed-by: Dave Cheney <dave@cheney.net> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Rob Pike
doc/go1.5.txt: io.CopyBuffer and new reflect.Value handling in fmt Change-Id: Ia0d7c2f08f8f124bcd62c7f9744227812d68903d Reviewed-on: https://go-review.googlesource.com/8941 Reviewed-by: Rob Pike <r@golang.org>
Branches
2 branches
Rob Pike
fmt: treat reflect.Value specially - as the value it holds When a reflect.Value is passed to Printf (etc.), fmt called the String method, which does not disclose its contents. To get the contents, one could call Value.Interface(), but that is illegal if the Value is not exported or otherwise forbidden. This CL improves the situation with a trivial change to the fmt package: when we see a reflect.Value as an argument, we treat it exactly as we treat a ref…
Branches
2 branches
Rob Pike
io: add CopyBuffer, a version of Copy in which the user provides a buffer This trivial addition to the io package makes it easy to control the buffer size and allocation properties of io.Copy. Change-Id: Ica1a6bd015e429d4e655bc0c6f66cea21c454acf Reviewed-on: https://go-review.googlesource.com/8730 Reviewed-by: Russ Cox <rsc@golang.org>
Branches
2 branches
Dave Cheney
cmd/internal/gc, cmd/7g: use zero register in Componentgen Fixes #9855 Use an architectural zero register as the source for zeroing, if available. Change-Id: Ie5b4ba4e3d356c6f892bfd1cebd14d5152bdeeb0 Reviewed-on: https://go-review.googlesource.com/8722 Reviewed-by: Keith Randall <khr@golang.org>
Branches
2 branches
Mikio Hara
net: add Listen system call hook for testing Change-Id: I63053c45081f47ba736720a78d85c31c13767891 Reviewed-on: https://go-review.googlesource.com/8642 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Branches
2 branches
Mikio Hara
net/internal/socktest: add hook for Listen, failed system call counters Change-Id: Icaac9a48a3b9a3c5542235162e21ab8303592965 Reviewed-on: https://go-review.googlesource.com/8641 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
Dave Cheney
runtime: mark all runtime.cputicks implementations NOSPLIT Fixes #10450 runtime.cputicks is called from runtime.exitsyscall and must not split the stack. cputicks is implemented in several ways and the NOSPLIT annotation was missing from a few of these. Change-Id: I5cbbb4e5888c5d298fe2fef240782d0e49f59af8 Reviewed-on: https://go-review.googlesource.com/8939 Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>
Branches
2 branches
brainman
runtime: really pass return value to Windows in externalthreadhandler When Windows calls externalthreadhandler it expects to receive return value in AX. We don't set AX anywhere. Change that. Store ctrlhandler1 and profileloop1 return values into AX before returning from externalthreadhandler. Fixes #10215. Change-Id: Ied04542cc3ebe7d4a26660e970f9f78098143591 Reviewed-on: https://go-review.googlesource.com/8901 Reviewed-by: Minux Ma <minux@golang.org> Run-TryBot: …
Branches
2 branches
Nigel Tao
image/png: reject multiple tRNS chunks. http://www.w3.org/TR/PNG/#5ChunkOrdering disallows them. Fixes #10423 Change-Id: I3399ce53dc8b41b1b5f0b906a5912e6efd80418f Reviewed-on: https://go-review.googlesource.com/8905 Reviewed-by: Rob Pike <r@golang.org>
Branches
2 branches
Robert Griesemer
go/importer: added go/importer package, adjusted go/types - The go/importer package provides access to compiler-specific importers. - Adjusted go/internal/gcimporter and go/types as needed. - types.Check was removed - not much simpler than calling types.Config.Check. - Package "unsafe" is now handled by the type checker; importers are not called for it anymore. - In std lib tests, re-use importer for faster testing (no need to re-import previously im…
Branches
2 branches
Josh Bleecher Snyder
misc/ios: read codesign info from environment variables Use environment variables to allow set-and-forget. Add a script to attempt to autodetect codesign info. Change-Id: Ic56b9c5f097b1a4117ebb89c408bc333d91f581d Reviewed-on: https://go-review.googlesource.com/8910 Reviewed-by: David Crawshaw <crawshaw@golang.org>
Branches
2 branches
Josh Bleecher Snyder
cmd/internal/gc: convert Bval to bool No functional changes. Passes toolstash -cmp. Change-Id: I4fba0c248645c3910ee3f7fc99dacafb676c5dc2 Reviewed-on: https://go-review.googlesource.com/8911 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Branches
2 branches
  1. Prev
  2. Next