Commits

Renato Santos  committed 5179fa0

Refactor code in effects to use data_priv. Re- Close gh-1244.

  • Participants
  • Parent commits 039371c

Comments (0)

Files changed (1)

File src/effects.js

 
 
 	// show/hide pass
-	dataShow = jQuery._data( elem, "fxshow" ) || jQuery._data( elem, "fxshow", {} );
+	dataShow = data_priv.get( elem, "fxshow" );
 	for ( index in props ) {
 		value = props[ index ];
 		if ( rfxtypes.exec( value ) ) {
 			if ( value === ( hidden ? "hide" : "show" ) ) {
 
 				// If there is dataShow left over from a stopped hide or show and we are going to proceed with show, we should pretend to be hidden
-				if( value === "show" && dataShow[ index ] !== undefined ) {
+				if( value === "show" && dataShow !== undefined && dataShow[ index ] !== undefined ) {
 					hidden = true;
 				} else {
-				continue;
-			}
+					continue;
+				}
 			}
 			handled.push( index );
 		}
 	}
 
 	length = handled.length;
-	if ( !length ) {
+	if ( length ) {
 		dataShow = data_priv.get( elem, "fxshow" ) || data_priv.access( elem, "fxshow", {} );
-	} else {
 		if ( "hidden" in dataShow ) {
 			hidden = dataShow.hidden;
 		}