Mvn downloading/running fails if the mvnvm.properties file is in DOS format

[Penny Wyatt]

Running on Cygwin on Windows 10, I cloned a repo containing a single-line mvnvm.properties file.

When running mvnvm, I got this corrupted output and nothing ran:

pwyatt@CLI-1964 /cygdrive/c/git/confluence-pdf-export-plugin
$ mvn clean install
[MVNVM] Using maven: 3.3.9
-bin.zip            downloading: apache-maven-3.3.9
-bin.zip                     to: /home/pwyatt/.mvnvm/apache-maven-3.3.9
-bin.zips/apache-maven-3.3.9ror: http://mirror.ventraip.net.au/apache/maven/maven-3/3.3.9
-bin.zips/apache-maven-3.3.9ive: https://archive.apache.org/dist/maven/maven-3/3.3.9
-bin.zip            old archive: https://archive.apache.org/dist/maven/binaries/apache-maven-3.3.9
-bin.zip     really old archive: https://archive.apache.org/dist/maven/binaries/maven-3.3.9
-bin.zip from any location apache-maven-3.3.9

The properties did not have a trailing line break, but opening it in vi, running ":set ff=unix" and saving again, resolved the issue.

[mjensenbitbucket-bot]

We should trim/cleanup the version number before using it, probably somewhere about here: https://bitbucket.org/mjensen/mvnvm/src/119faadcd15b86d2d7c0894ec52b8bc44a3114a9/mvn?at=master&fileviewer=file-view-default#mvn-374

[Karl-Heinz Marbaise]

I would suggest to download the tar.gz archive instead of the zip cause the ZIP is intended for Windows whereas the tar.gz is for unix based systems.