Commits

Tuukka Norri committed 24a790d

Small changes
- BXPGEntityImporter now checks that the entities that might require DROP statements have actually been validated.
- BXLogger now emits a warning instead of an error from BXDeprecationWarning.

  • Participants
  • Parent commits 95c73e1

Comments (0)

Files changed (4)

File Sources/BXDatabaseObjectModel.m

 	if (! [schemaName length])
 		schemaName = @"public";
 	
-	NSMutableDictionary* schemaDict = nil;
 	BXEntityDescription* retval = nil;
 	@synchronized (mEntitiesBySchemaAndName)
 	{
-		schemaDict = [[[mEntitiesBySchemaAndName objectForKey: schemaName] retain] autorelease];
+		NSMutableDictionary *schemaDict = [mEntitiesBySchemaAndName objectForKey: schemaName];
 		if (! schemaDict)
 		{
 			schemaDict = [NSMutableDictionary dictionary];

File Sources/BXLogger.m

 void
 BXDeprecationWarning ()
 {
-	BXLogError (@"Break on BXDeprecationWarning to inspect.");
+	BXLogWarning (@"Break on BXDeprecationWarning to inspect.");
 }
 
 

File Sources/BXPGEntityImporter.m

 								 inSchema: (NSString *) schemaName
 									error: (NSError **) outError
 {
-	return [[mContext databaseObjectModel] matchingEntity: importedEntity inSchema: schemaName];
+	BXEntityDescription *retval = [[mContext databaseObjectModel] matchingEntity: importedEntity inSchema: schemaName];
+	ExpectL ([retval isValidated]);
+	return retval;
 }
 
 

File Sources/BXPGInterface.m

 			
 			//Attributes
 			{
-				//FIXME: Handle inherited attributes!
-				
 				[currentAttributes removeAllObjects];
 				NSDictionary* columns = [table columns];
 				NSSet* pkeyColumns = [[table primaryKey] columns];