Commits

Tuukka Norri committed 99a808e

Bug fix
- Removed tests like -[object isFaultKey: nil]. Nowadays we are able to fetch system fields but they are excluded by default, and giving this method a nil key checks them, too. Thus we got false positives. I'm a bit surprised, though, why this didn't occur in today's earlier test runs.

  • Participants
  • Parent commits ad908c3
  • Branches PGTS-NG

Comments (0)

Files changed (3)

File UnitTests/FetchTests.m

 	STAssertNil (error, [error localizedDescription]);
 	
 	FetchTestObject* object = [res objectAtIndex: 0];
-	MKCAssertFalse ([object isFaultKey: nil]);
 	MKCAssertFalse ([object isFaultKey: @"value"]);
 	
 	object->didTurnIntoFault = NO;
 	[object valueForKey: @"value"];
 	[context refreshObject: object mergeChanges: YES];
 	MKCAssertFalse (object->didTurnIntoFault);
-	MKCAssertFalse ([object isFaultKey: nil]);
 	MKCAssertFalse ([object isFaultKey: @"value"]);
 	
 	object->didTurnIntoFault = NO;
 		
 	[entity setDatabaseObjectClass: nil];
 }
-
 @end

File UnitTests/TestLoader.m

 		nil] objectEnumerator]];
 	
 	SenTestRun* run = [bxSuite run];
-    //SenTestRun* run = [(SenTestSuite *) [SenTestSuite testSuiteForTestCaseClass: [ForeignKeyTests class]] run];
+    //SenTestRun* run = [(SenTestSuite *) [SenTestSuite testSuiteForTestCaseClass: [FetchTests class]] run];
 	STAssertTrue (0 == [run failureCount], @"Expected tests to succeed.");
 }
 @end

File UnitTests/UnitTests.xcodeproj/project.pbxproj

 		5317CEB60D1ACB0D00A48792 /* MTMCollectionTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 5321BEAC0AD4DCDD0011D0C8 /* MTMCollectionTest.m */; };
 		5317CEB70D1ACB0E00A48792 /* ModificationTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 5373A65D0A6D3F9A0036424B /* ModificationTests.m */; };
 		5317CEB80D1ACB0E00A48792 /* ForeignKeyTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 53EAD1B50A668733008F3CE5 /* ForeignKeyTests.m */; };
-		5317CEB90D1ACB0F00A48792 /* FetchTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 53BD965B0A5C1BA5001C950C /* FetchTests.m */; };
 		5317CEBA0D1ACB1000A48792 /* EntityTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 531E118C0A6A3A6C003A0F23 /* EntityTests.m */; };
 		5317CEBB0D1ACB1000A48792 /* CreateTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 53BD96760A5C1DC3001C950C /* CreateTests.m */; };
 		5317CEBC0D1ACB1100A48792 /* ConnectTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 530A439E0A5C114E00A4722B /* ConnectTest.m */; };
 		53193F0A0BC51702009A77EC /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53193E8D0BC51701009A77EC /* Foundation.framework */; };
 		538263C80CD0EC8100CF7E2D /* ForeignKeyModificationTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 539C51290C4E4EE000080667 /* ForeignKeyModificationTests.m */; };
 		539385110B3940C80017E26E /* SenTestingKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53BD96BE0A5C2501001C950C /* SenTestingKit.framework */; };
+		53A59C560E3509CE0026D7E1 /* FetchTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 53BD965B0A5C1BA5001C950C /* FetchTests.m */; };
 		53C98A140CF0803A00D6A0A7 /* TestLoader.m in Sources */ = {isa = PBXBuildFile; fileRef = 535059B30CDA1CFC00DA25EC /* TestLoader.m */; };
 		53D03BA90DE828CB002D14C4 /* BaseTen.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 538B40F50D634EA40009005B /* BaseTen.framework */; };
 		53F8E1DD0CBF7FF100C000C5 /* UnitTestAdditions.m in Sources */ = {isa = PBXBuildFile; fileRef = 53A494840BD4D92F008E850E /* UnitTestAdditions.m */; };
 				5317CEB60D1ACB0D00A48792 /* MTMCollectionTest.m in Sources */,
 				5317CEB70D1ACB0E00A48792 /* ModificationTests.m in Sources */,
 				5317CEB80D1ACB0E00A48792 /* ForeignKeyTests.m in Sources */,
-				5317CEB90D1ACB0F00A48792 /* FetchTests.m in Sources */,
 				5317CEBA0D1ACB1000A48792 /* EntityTests.m in Sources */,
 				5317CEBB0D1ACB1000A48792 /* CreateTests.m in Sources */,
 				5317CEBC0D1ACB1100A48792 /* ConnectTest.m in Sources */,
+				53A59C560E3509CE0026D7E1 /* FetchTests.m in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};