Commits

Tuukka Norri committed f0e06ba

Removed some fixmes and set the library name for Log4Cocoa

Comments (0)

Files changed (4)

Framework/Sources/PGTSConnectionPrivate.m

 - (void) didChangeValueForKey: (NSString *) key;
 @end
 
-//FIXME: what is this?
+
 #if 0
+//Check for key-value observing capability.
 @interface NSObject (PGTSKVO)
 + (BOOL) PGTSAllowKVO;
 @end
                                                  object: self
                                                userInfo: userInfo];
     if (delegateProcessesNotices)
-    {
-        //[delegate PGTSConnection: nil receivedNotice: notification]; //FIXME: come up with a way to pass the connection object
-        //update: I really cannot understand, what was supposed to be the problem with this. Can't I just use 'self'?
         [delegate PGTSConnection: self receivedNotice: notification];
-    }
+
     [self logNotice: message];
 }
 

Framework/Sources/PGTSFunctions.m

 int
 PGTSVerifySSLCertificate (int preverify_ok, void* x509_ctx)
 {
-	//FIXME: this function should have a run loop, if possible, and run it until the result has been received.
-	//This way, we can use ordinary Cocoa sheets.
 	SSL* ssl = X509_STORE_CTX_get_ex_data ((X509_STORE_CTX *) x509_ctx, SSL_get_ex_data_X509_STORE_CTX_idx ());
 	PGTSConnection* connection = SSL_get_ex_data (ssl, PGTSSSLConnectionExIndex ());
 	int rval = (YES == [[connection certificateVerificationDelegate] PGTSAllowSSLForConnection: connection context: x509_ctx preverifyStatus: preverify_ok]);

Framework/Sources/PGTSResultSet.m

 
 - (id) valueForKey: (NSString *) aKey
 {
-    //FIXME: unknown key? We probably shouldn't return nil
+	//Unknown key raises an exception.
     return [self valueForFieldNamed: aKey];
 }
 

Framework/Sources/PGTS_Prefix.pch

 #ifdef __OBJC__
     #import <Foundation/Foundation.h>
 #endif
+#define L4_CURRENT_LIBRARY "PGTS"
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.