Unnecessary resampling

ryandesign avatarryandesign created an issue

makeicns seems to be resampling unnecessarily. Example from the build of QupZilla 1.1.0_2 in MacPorts:

:notice:build --->  Building QupZilla
:debug:build Executing proc-pre-org.macports.build-build-0
:info:build 2012-01-04 20:19:10.394 makeicns[8166:907] Resampling for 257 wide x 257 high
:info:build 2012-01-04 20:19:10.521 makeicns[8166:907] Resampling for 129 wide x 129 high
:info:build 2012-01-04 20:19:10.532 makeicns[8166:907] Resampling for 33 wide x 33 high
:info:build 2012-01-04 20:19:10.536 makeicns[8166:907] Resampling for 17 wide x 17 high
:info:build 2012-01-04 20:19:10.561 makeicns[8166:907] Wrote output file "src/qupzilla.icns"

The command used to invoke makeicns was:

$ makeicns \
-256 linux/hicolor/256x256/qupzilla.png \
-128 linux/hicolor/128x128/qupzilla.png \
-32 linux/hicolor/32x32/qupzilla.png \
-16 linux/hicolor/16x16/qupzilla.png \
-out src/qupzilla.icns

No resampling should have been necessary since the files are already the right size:

$ file linux/hicolor/*/*.png
linux/hicolor/128x128/qupzilla.png: PNG image data, 128 x 128, 8-bit/color RGBA, non-interlaced
linux/hicolor/16x16/qupzilla.png:   PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced
linux/hicolor/256x256/qupzilla.png: PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
linux/hicolor/32x32/qupzilla.png:   PNG image data, 32 x 32, 8-bit/color RGBA, non-interlaced
linux/hicolor/48x48/qupzilla.png:   PNG image data, 48 x 48, 8-bit colormap, non-interlaced
linux/hicolor/64x64/qupzilla.png:   PNG image data, 64 x 64, 8-bit/color RGBA, non-interlaced

Comments (5)

  1. Marko Käning
    • changed status to open

    Ooops, this looks very odd. So far I've never seen that this kind of resampling occurs, especially since it is always +1 pixel off. We need to check this. Thanks for reporting, Ryan!

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.