1. Michael Ludwig
  2. entreri
  3. Issues
Issue #38 resolved

Decide on access level for ComponentRepository and AbstractComponent

Michael Ludwig
repo owner created an issue

It turns out that ComponentRepository and AbstractComponent cannot be package-private and still be used with Janino because Janino uses a separate class-loader and thus does not have permission to access those classes when it tries to install the newly defined component type.

I must make them public, but then this influences my previous decisions, namely:

  1. Should component proxies go in their type's package?
  2. Should ComponentRepository, etc. be moved into an impl package to keep the core clean?
  3. Should other package-private classes be made public for consistency now?

Comments (3)

  1. Log in to comment