Commits

Mike Podonyi  committed 78ac64f

some notes

  • Participants
  • Parent commits 5834bd7

Comments (0)

Files changed (1)

File src/Empi.Camino/Configuration/CaminoSettingsProvider.cs

         public override SettingsPropertyValueCollection GetPropertyValues(SettingsContext context, SettingsPropertyCollection collection)
         {
             SettingsPropertyValueCollection settingsPropertyValueCollection =new SettingsPropertyValueCollection();
+            //MP:should operate on a more Common RepositoryName 
             RetailerDataRepository<Empi.Camino.Data.IConfigurationBase> retailerDataConfiguration=RetailerDataRepository<Empi.Camino.Data.IConfigurationBase>.GetCachedRetailerDataRepository;
 
             foreach(SettingsProperty settingsProperty in collection)
             {
+				//MP: DataContextFactory should also be applied
                 var conf=retailerDataConfiguration.SingleOrDefault(c=> c.Key==settingsProperty.Name, (Type)context["ConfigurationTableType"]);
                 if(conf!=null)
                 {
 
         public override void SetPropertyValues(SettingsContext context, SettingsPropertyValueCollection collection)
         {
+            //MP:should operate on a more Common RepositoryName
             RetailerDataRepository<Empi.Camino.Data.IConfigurationBase> retailerDataConfiguration = RetailerDataRepository<Empi.Camino.Data.IConfigurationBase>.GetCachedRetailerDataRepository;
 
             foreach (var settingsPropertyValue in from item in collection.Cast<SettingsPropertyValue>() where item.IsDirty select item)
             {
+				//MP: DataContextFactory should also be applied
                 var conf = retailerDataConfiguration.SingleOrDefault(c => c.Key == settingsPropertyValue.Name, (Type)context["ConfigurationTableType"]);
                 if (conf != null)
                 {