blargg_source.h inclusion in gme.h is harmful
Issue #244
resolved
Public header gme.h includes blargg_source.h only for BLARGG_EXPORT macro.
However blargg_source.h contains macros with not unique names at all, and
they can clash with any users of the library.
I suggest duplicating BLARGG_EXPORT macro in gme.h and removing inclusion
of blargg_source.h.
Pull request pending.
Comments (2)
-
reporter -
Account Deactivated - changed status to resolved
- Log in to comment
Submitted https://bitbucket.org/mpyne/game-music-emu/pull-requests/39 for this