Vgm_Emu: psg_dual is used uninitialized

@{557058:5ed93255-b721-4541-b8d7-25ca65e4445c} , @Michael Pyne : This, found by valgrind:

Loading file ../../test.vgz by file path...
==26165== Conditional jump or move depends on uninitialised value(s)
==26165==    at 0x41E3509: Vgm_Emu::update_eq(blip_eq_t const&) (Vgm_Emu.cpp:262)
==26165==    by 0x41A0469: Classic_Emu::set_equalizer_(gme_equalizer_t const&) (Classic_Emu.cpp:41)
==26165==    by 0x41AC9BB: Music_Emu::set_equalizer(gme_equalizer_t const&) (Music_Emu.cpp:101)
==26165==    by 0x41E2D44: Vgm_Emu::Vgm_Emu() (Vgm_Emu.cpp:43)
==26165==    by 0x41E32DE: new_vgm_emu() (Vgm_Emu.cpp:206)
==26165==    by 0x41A8E62: gme_internal_new_emu_(gme_type_t_ const*, int, bool) (gme.cpp:223)
==26165==    by 0x41A8FC8: gme_new_emu (gme.cpp:260)
==26165==    by 0x41A8CCF: gme_open_file (gme.cpp:186)
==26165==    by 0x804A480: Music_Player::load_file(char const*, bool) (Music_Player.cpp:115)
==26165==    by 0x804AD82: main (player.cpp:121)

‌

Unconditionally calling psg[1].treble_eq( eq ); in Vgm_Emu::update_eq() surely removes the warning. Should I send a pull request as such unless you guys have a better solution?

Comments (3)