- changed status to resolved
no "using namespace" please in public header files
Issue #6
resolved
Hi -
I would personally not do this in libraries I ship to others:
include/hcfftlib.h:using namespace hc;
include/hcfftlib.h:using namespace hc::short_vector;
or even worse this:
include/lock.h:using namespace std;
include/stockham.h:using namespace std;
feel free to do this inside .cpp files, but not in headers. this will produce name conflicts with client code that by chance also has a e.g. CopyGenerator
or similar.
Comments (2)
-
-
reporter very good, thanks!
- Log in to comment
Fixed in commit 7a6e1f3