add i486, i586, and i686 names to x86 CPU detection in CMakeLists.txt

Issue #33 resolved
Former user created an issue

In my case, it's not correctly detecting i686 as an x86 processor, and disables the ASM. Altering the reference from i386 to i686 in CMakeLists.txt, or more preferably, adding a check for it in addition to the i386 check allows the ASM to build again. Checks for i486 and i586 names should probably also be added just in case.

Using Ubuntu 13.10. When cross-compiling with i686-w64-mingw32, it detects correctly (probably because that inherently means it's not meant for the same OS, so whatever the OS identifies its architecture as means nothing - or that MinGW-w64 makes sure that it identifies itself as a generic i386 for 32-bit), but it's the native builds that get tripped up.

$ uname -a
Linux ubuntu-desktop 3.11.0-17-generic #31-Ubuntu SMP Mon Feb 3 21:53:31 UTC 2014 i686 i686 i686 GNU/Linux

$ cmake . -DENABLE_SHARED:bool=off
-- cmake version 2.8.11.2
-- The C compiler identification is GNU 4.8.1
-- The CXX compiler identification is GNU 4.8.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- CMAKE_SYSTEM_PROCESSOR value `i686` is unknown
-- Please add this value near /home/qyot27/x265/source/CMakeLists.txt:46
-- Performing Test GCC_HAS_NO_NARROWING
-- Performing Test GCC_HAS_NO_NARROWING - Success
-- Performing Test GCC_HAS_STACK_REALIGN
-- Performing Test GCC_HAS_STACK_REALIGN - Success
-- Found yasm: /usr/bin/yasm (found version "1.2.0") 
-- x265 version 0.7+356-000f86d72337
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - found
-- Looking for include file getopt.h
-- Looking for include file getopt.h - found
-- Configuring done
-- Generating done
-- Build files have been written to: /home/qyot27/x265/source

Comments (1)

  1. Log in to comment