patch 69f316d001b5 breaks 2pass encoding

Issue #354 resolved
Ma0 created an issue

x265 ver. 2.4+84-586d06ad195a works fine with 2pass encoding, ver. 2.4+85-69f316d001b5 works bad. Problem is with first pass that saves "x265_2pass.log" file wrong -- it is at the end of each line "icu:nan pcu:nan scu:nan ;"

Comments (4)

  1. Ma0 reporter

    After this change 2pass encoding works again:

    diff -r 5f2330bdb8fa source/encoder/frameencoder.cpp
    --- a/source/encoder/frameencoder.cpp   Fri Jun 23 14:49:50 2017 +0530
    +++ b/source/encoder/frameencoder.cpp   Sun Jun 25 17:36:18 2017 +0200
    @@ -1798,7 +1798,7 @@
             totQP += ctu.m_qp[absPartIdx] * (ctu.m_numPartitions >> (depth * 2));
         }
    
    -    if (m_param->csvLogLevel >= 1)
    +    if (m_param->csvLogLevel >= 1 || m_param->rc.bStatWrite)
         {
             if (ctu.m_slice->m_sliceType == I_SLICE)
             { 
    

    I don't know if this patch is OK -- somebody with more knowledge should look at this.

  2. Pradeep Ramachandran Account Deactivated

    Thanks for the note. I notice it also in my regressions. We will fix this with a patch.

  3. Pradeep Ramachandran Account Deactivated

    We've pushed in changeset fa076d29d619 that should fix this issue. Can you please confirm if with this change things look ok on your end?

  4. Log in to comment